I have a function for checking the type of a $value is valid or not. My current code is a simple switch case with too many cases exceeding the cyclomatic complexity to 17. I need to add more cases as well as reduce the complexity.
/**
* Check type of attribute value
* @param $type
* @param $value
* @return bool
*/
public function typeCheck($type, $value)
{
$this->value = $value;
switch ($type) {
case 'string':
return is_string($value) || is_integer($value) || is_bool($value);
case 'StringNotNull':
return is_string($value);
case 'LongStringNotNull':
return is_string($value);
case 'SuperLongStringNotNull':
return is_string($value);
case 'FortyStringNotNull':
return is_string($value) && (strlen($value) < 41);
case 'integer':
return is_numeric($value);
case 'positiveInteger':
return is_numeric($value) && ($value > 0);
case 'boolean':
return is_bool($value) || ($value == 'true' || $value = 'false');
case 'float':
return is_numeric($value);
case 'decimal':
return is_numeric($value);
case 'PositiveDimension':
return is_numeric($value) && ($value > 0);
case 'Dimension':
return is_numeric($value) && (strlen($value) < 13);
case 'Barcode':
$validator = $this->getBarcodeValidator();
$validator->setBarcode($value);
return is_string($value) && (strlen($value) < 17 && $validator->isValid());
case 'dateTime':
return true;
case 'normalizedString':
$this->value = strip_tags($value);
return is_string($value);
default:
return is_string($value);
}
}
Any better way around?
Aucun commentaire:
Enregistrer un commentaire